Skip to content

Fix AWS V2 Client TLS Config Error #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArnobKumarSaha merged 1 commit into from
Oct 8, 2025
Merged

Fix AWS V2 Client TLS Config Error #74

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions pkg/blob/blob.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ import (
api "kmodules.xyz/objectstore-api/api/v1"

aws2 "github.com/aws/aws-sdk-go-v2/aws"
awshttp "github.com/aws/aws-sdk-go-v2/aws/transport/http"
"github.com/aws/aws-sdk-go-v2/config"
"github.com/aws/aws-sdk-go-v2/credentials"
"github.com/aws/aws-sdk-go-v2/service/s3"
Expand Down Expand Up @@ -503,7 +504,7 @@ func (b *Blob) getS3Config(ctx context.Context, debug bool) (aws2.Config, error)
return config.LoadDefaultConfig(ctx, loadOptions...)
}

func configureTLS(caCert []byte, insecureTLS bool) (*http.Client, error) {
func configureTLS(caCert []byte, insecureTLS bool) (*awshttp.BuildableClient, error) {
tlsConfig := &tls.Config{
InsecureSkipVerify: insecureTLS,
}
Expand All @@ -514,12 +515,12 @@ func configureTLS(caCert []byte, insecureTLS bool) (*http.Client, error) {
}
tlsConfig.RootCAs = caCertPool
}
rt := http.DefaultTransport.(*http.Transport).Clone()
rt.TLSClientConfig = tlsConfig
buildableClient := awshttp.NewBuildableClient().WithTransportOptions(func(tr *http.Transport) {
tr.TLSClientConfig = tlsConfig
})
// https://docs.aws.amazon.com/sdk-for-go/v2/developer-guide/configure-http.html#transport

return &http.Client{
Transport: rt,
}, nil
return buildableClient, nil
}

func (b *Blob) SetPathAsDir(ctx context.Context, path string) error {
Expand Down
Loading