Fix(frontend)/apply feedback round 1 #90
There are no files selected for viewing
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| import React from "react"; | ||
|
|
||
| import Image from "next/image"; | ||
|
|
||
| import { request } from "@/utils/graphQLClient"; | ||
|
|
||
| import { heroQuery, HeroQueryType } from "../queries/hero"; | ||
|
|
||
| const Hero: React.FC = async () => { | ||
| const { header, subtitle, background } = ( | ||
| await request<HeroQueryType>(heroQuery) | ||
| ).forLawyersPageHero; | ||
|
|
||
| return ( | ||
| <div className="relative px-6 pb-64 pt-44 md:pt-52 lg:px-32 lg:pb-80"> | ||
| <div className="space-y-8"> | ||
| <h1 | ||
| className={ | ||
| "pt-1 text-2xl font-medium text-primary-text lg:pt-3 lg:text-4xl" | ||
| } | ||
| > | ||
| {header} | ||
| </h1> | ||
| <p className="max-w-[685px] text-lg text-primary-text">{subtitle}</p> | ||
| </div> | ||
| <Image | ||
| src={background.url} | ||
| alt="Hero Image Background" | ||
| fill | ||
| unoptimized | ||
| className="absolute left-0 top-0 z-[-1] h-full object-cover" | ||
| /> | ||
| </div> | ||
| ); | ||
| }; | ||
|
|
||
| export default Hero; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,41 @@ | ||||||||||||||||||||||||||||||||||
| import React from "react"; | ||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||
| import clsx from "clsx"; | ||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||
| import CtaCard from "@/components/CtaCard"; | ||||||||||||||||||||||||||||||||||
| import { request } from "@/utils/graphQLClient"; | ||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||
| import { enterpriseQuery, IEnterpriseQuery } from "./queries"; | ||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||
| const Web3: React.FC = async () => { | ||||||||||||||||||||||||||||||||||
| const { title, subtitle, cards } = await request<IEnterpriseQuery>( | ||||||||||||||||||||||||||||||||||
| enterpriseQuery, | ||||||||||||||||||||||||||||||||||
| ).then(({ homeEnterprise }) => homeEnterprise); | ||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||
|
Comment on lines
+10
to
+14
Contributor
There was a problem hiding this comment. 🛠️ Refactor suggestion Add error handling for GraphQL request. The component lacks error handling for the GraphQL request. Consider adding try/catch to handle potential network failures or server errors. -const Web3: React.FC = async () => {
- const { title, subtitle, cards } = await request<IEnterpriseQuery>(
- enterpriseQuery,
- ).then(({ homeEnterprise }) => homeEnterprise);
+const Enterprise: React.FC = async () => {
+ try {
+ const { title, subtitle, cards } = await request<IEnterpriseQuery>(
+ enterpriseQuery,
+ ).then(({ homeEnterprise }) => homeEnterprise);
+
+ // Component rendering code...
+ } catch (error) {
+ console.error("Failed to fetch Enterprise data:", error);
+ return <div>Failed to load Enterprise section. Please try again later.</div>;
+ }📝 Committable suggestion
Suggested change
|
||||||||||||||||||||||||||||||||||
| return ( | ||||||||||||||||||||||||||||||||||
| <div className="bg-background-1 px-6 pb-12 pt-6 lg:px-32 lg:pb-24 lg:pt-12"> | ||||||||||||||||||||||||||||||||||
| <div className="flex flex-col gap-8"> | ||||||||||||||||||||||||||||||||||
| <h3 className="text-xl font-medium text-primary-text lg:text-3xl"> | ||||||||||||||||||||||||||||||||||
| {title} | ||||||||||||||||||||||||||||||||||
| </h3> | ||||||||||||||||||||||||||||||||||
| <p className="text-base text-primary-text lg:text-lg">{subtitle}</p> | ||||||||||||||||||||||||||||||||||
| <div | ||||||||||||||||||||||||||||||||||
| className={clsx( | ||||||||||||||||||||||||||||||||||
| "mx-auto mb-12 mt-4 flex flex-wrap gap-4", | ||||||||||||||||||||||||||||||||||
| "xl:mt-16 xl:grid xl:grid-cols-3", | ||||||||||||||||||||||||||||||||||
| )} | ||||||||||||||||||||||||||||||||||
| > | ||||||||||||||||||||||||||||||||||
| {cards.map(({ icon, title, subtitle }) => ( | ||||||||||||||||||||||||||||||||||
| <CtaCard | ||||||||||||||||||||||||||||||||||
| className="flex-grow" | ||||||||||||||||||||||||||||||||||
| key={title} | ||||||||||||||||||||||||||||||||||
| {...{ icon, title, description: subtitle }} | ||||||||||||||||||||||||||||||||||
| /> | ||||||||||||||||||||||||||||||||||
| ))} | ||||||||||||||||||||||||||||||||||
| </div> | ||||||||||||||||||||||||||||||||||
| </div> | ||||||||||||||||||||||||||||||||||
| </div> | ||||||||||||||||||||||||||||||||||
| ); | ||||||||||||||||||||||||||||||||||
| }; | ||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||
| export default Web3; | ||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| import { gql } from "graphql-request"; | ||
|
|
||
| export const enterpriseQuery = gql` | ||
| { | ||
| homeEnterprise { | ||
| title | ||
| subtitle | ||
| cards { | ||
| icon { | ||
| url | ||
| } | ||
| title | ||
| subtitle | ||
| } | ||
| } | ||
| } | ||
| `; | ||
|
|
||
| export type IEnterpriseQuery = { | ||
| homeEnterprise: { | ||
| title: string; | ||
| subtitle: string; | ||
| cards: Array<{ | ||
| icon: { | ||
| url: string; | ||
| }; | ||
| title: string; | ||
| subtitle: string; | ||
| }>; | ||
| }; | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Component naming doesn't match folder structure.
The component is named
Web3but is located in the Enterprise folder and uses enterprise data. This is confusing and should be corrected for maintainability.Also, remember to update the export at the bottom of the file:
📝 Committable suggestion