fix(web): withdraw-appeal-fees-maintainance-button

[tractorss]

PR-Codex overview

This PR simplifies the logic in the WithdrawAppealFees.tsx file by removing a nested loop, which iterated over round. Now, it directly pushes a single set of arguments for each contribution, streamlining the argument preparation for setContractConfigs.

Detailed summary

• Removed the nested loop that iterated over round.
• Updated the argsArr.push to only include contribution.choice without the round parameter.
• Simplified the argument preparation for setContractConfigs.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

Release Notes

• Refactor
  • Streamlined appeal fee withdrawal transactions for faster processing and improved efficiency

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[netlify]

❌ Deploy Preview for kleros-v2-testnet-devtools failed. Why did it fail? →

Name	Link
🔨 Latest commit	dba605c
🔍 Latest deploy log	https://app.netlify.com/projects/kleros-v2-testnet-devtools/deploys/69447347d8e6ec000808e699

[coderabbitai]

Walkthrough

The WithdrawAppealFees component's transaction batch generation logic was simplified. Previously, the code emitted multiple transaction calls per contribution—one for each round iteration from roundIndex down to 0. Now it emits a single call per contribution, with transaction arguments reduced to id, contributor.id, and contribution.choice.

Changes

Cohort / File(s)	Summary
WithdrawAppealFees logic simplification web/src/pages/Cases/CaseDetails/MaintenanceButtons/WithdrawAppealFees.tsx	Removed per-round argument generation; transaction batch now emits single call per contribution instead of multiple calls across rounds. Updated withdrawFeesAndRewards args to drop round parameter.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Single file modification with localized logic changes
• Verify batching logic correctly consolidates contributions into single calls
• Confirm transaction argument structure matches expected withdrawFeesAndRewards signature

Poem

A rabbit hops through code so bright,
Round loops removed—what a delight!
One call per gift, no rounds to chase,
Simplicity blooms in this tranquil space. 🐰✨

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title is vague and lacks specificity about the actual changes made. While it mentions 'withdraw-appeal-fees-maintainance-button', the summary shows the key change is removing per-round argument generation and simplifying transaction batching logic—details that are not captured in the title.	Consider a more descriptive title like 'fix: simplify withdraw appeal fees batching logic by removing per-round calls' to better convey the primary architectural change.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch chore/update-withdraw-fees-maintainance-button

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[netlify]

❌ Deploy Preview for kleros-v2-neo failed. Why did it fail? →

Name	Link
🔨 Latest commit	dba605c
🔍 Latest deploy log	https://app.netlify.com/projects/kleros-v2-neo/deploys/694473476469f00008a36716

[netlify]

✅ Deploy Preview for kleros-v2-testnet ready!

Name	Link
🔨 Latest commit	dba605c
🔍 Latest deploy log	https://app.netlify.com/projects/kleros-v2-testnet/deploys/69447347d861cb0008353df3
😎 Deploy Preview	https://deploy-preview-2206--kleros-v2-testnet.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

web/src/pages/Cases/CaseDetails/MaintenanceButtons/WithdrawAppealFees.tsx (2)

76-76: Remove unused roundIndex from dependencies.

The roundIndex is included in the useEffect dependencies but is no longer used within the effect body after the logic simplification. This causes unnecessary re-execution of the effect when roundIndex changes.

🔎 Apply this diff to remove the unused dependency:

-  }, [id, roundIndex, chainId, filteredContributions]);
+  }, [id, chainId, filteredContributions]);

---

26-32: Remove roundIndex prop or clarify its purpose.

The roundIndex parameter is passed from the parent component but is never used in transaction generation logic. It only serves as an undefined guard check at line 58. Either remove it entirely (updating both the interface and parent component usage), or document why the guard is necessary if it serves a specific purpose.

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4cdb9f9 and 9f72187.

📒 Files selected for processing (1)

• web/src/pages/Cases/CaseDetails/MaintenanceButtons/WithdrawAppealFees.tsx (1 hunks)

🧰 Additional context used

🧠 Learnings (2)

📓 Common learnings

Learnt from: Harman-singh-waraich
Repo: kleros/kleros-v2 PR: 1775
File: web/src/pages/Courts/CourtDetails/StakePanel/StakeWithdrawButton.tsx:0-0
Timestamp: 2024-12-09T12:36:59.441Z
Learning: In the `StakeWithdrawButton` component, the transaction flow logic is tightly linked to component updates, so extracting it into a custom hook does not provide significant benefits.

📚 Learning: 2024-12-09T12:36:59.441Z

Learnt from: Harman-singh-waraich
Repo: kleros/kleros-v2 PR: 1775
File: web/src/pages/Courts/CourtDetails/StakePanel/StakeWithdrawButton.tsx:0-0
Timestamp: 2024-12-09T12:36:59.441Z
Learning: In the `StakeWithdrawButton` component, the transaction flow logic is tightly linked to component updates, so extracting it into a custom hook does not provide significant benefits.

Applied to files:

• web/src/pages/Cases/CaseDetails/MaintenanceButtons/WithdrawAppealFees.tsx

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (14)

• GitHub Check: Redirect rules - kleros-v2-testnet
• GitHub Check: Redirect rules - kleros-v2-testnet
• GitHub Check: Header rules - kleros-v2-testnet
• GitHub Check: Header rules - kleros-v2-testnet
• GitHub Check: Pages changed - kleros-v2-testnet
• GitHub Check: Pages changed - kleros-v2-testnet
• GitHub Check: Redirect rules - kleros-v2-neo
• GitHub Check: Header rules - kleros-v2-neo
• GitHub Check: Pages changed - kleros-v2-neo
• GitHub Check: Redirect rules - kleros-v2-testnet-devtools
• GitHub Check: hardhat-tests
• GitHub Check: Analyze (javascript)
• GitHub Check: Header rules - kleros-v2-testnet-devtools
• GitHub Check: Pages changed - kleros-v2-testnet-devtools

🔇 Additional comments (1)

web/src/pages/Cases/CaseDetails/MaintenanceButtons/WithdrawAppealFees.tsx (1)

69-72: No review comment was provided for rewriting. Please provide the review comment you would like me to verify and rewrite.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud