-
Notifications
You must be signed in to change notification settings - Fork 289
now sets klaro-modal-open to body klaro-modal is open #403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dersimoezdag
wants to merge
2
commits into
kiprotect:master
Choose a base branch
from
dersimoezdag:modal-open-class-to-document.body
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
now sets klaro-modal-open to body klaro-modal is open #403
dersimoezdag
wants to merge
2
commits into
kiprotect:master
from
dersimoezdag:modal-open-class-to-document.body
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks again, very useful! |
Member
|
I'll have to merge this manually as there are some conflicts. |
Contributor
Author
|
@adewes i've resolved the conflicts :) |
|
Would be happy to see this merged, we discussed about the same feature yesterday |
|
up |
Contributor
|
@adewes this seems not to be merged into the current release. It would be great to see this happen. |
Jako
added a commit
to Jako/klaro-js
that referenced
this pull request
Dec 16, 2025
Jako
added a commit
to Jako/klaro-js
that referenced
this pull request
Dec 16, 2025
* modal-open-class: Rebase kiprotect#403 now sets klaro-modal-open to body klaro-modal is open
Jako
added a commit
to Jako/klaro-js
that referenced
this pull request
Dec 16, 2025
Jako
added a commit
to Jako/klaro-js
that referenced
this pull request
Dec 16, 2025
* modal-open-class: Rebase kiprotect#403 now sets klaro-modal-open to body klaro-modal is open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the user to prevent scrolling in background of the klaro modal.
CSS:
body.modal-open { overflow: hidden; padding-right: var(--scrollbar-width); }