Open
Conversation
Collaborator
|
Hello @songm0428, thanks for opening this pull request and creating these features. It looks like you are adding two classes that provide interesting new examples. @kinneerc, I am in favor of accepting this pull request. Can you please try the new example and see if you agree with my suggestion? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To enhance this code, we implemented methods prefixAverage1 (which we called prefix1) and prefixAverage2 (which we called prefix2). We run these methods in prefixExperiment. Within these methods, we changed the doubles to integers and changed corresponding parameters, etc. We also included Javadoc commenting so that the next user of this program has some type of way of understanding the code that we implemented.