Fixed spelling of 'quadradic' and added feature to alg input#2
Fixed spelling of 'quadradic' and added feature to alg input#2mariakimheinert wants to merge 2 commits intokinneerc:masterfrom mariakimheinert:fix-quadradic-add-valid-alg-checking
Conversation
… of inputted name of algorithm
|
Hi @Kimmaria, thanks for fixing those spelling errors. Performing input validation is also good idea . I tested your branch and everything seems to work. Thanks for your help! One way to extend the input validation feature would be to output the list of accepted arguments when the user provides one that is unsupported. Whenever I forget what the valid arguments are, I have to look in the source code to see what strings are recognized. Having a message like this would be helpful: Also, as a minor nitpick point, maybe we should change the new I am in favor of merging this pull request, what do you think @gkapfham? |
|
Hi there, @kinneerc. I implemented your suggestions and committed the change. Please let me know if you have any other suggestions. Thank you! |
|
Thanks @mariakimbap for adding this feature. @kinneerc, it looks like @mariakimbap has added some improvements to the system. I would like to see, in particular, the spelling mistakes in the output fixed. Also, this new feature of parameter checking seems useful. As long as you still agree, @kinneerc, I suggest that you merge this pull request. |
$ java edu.allegheny.expose.examples.unique.UniqueExperiment bubble --verboseand it would still run the experiment, though for which algorithm I'm not sure. Now, if you run$ java edu.allegheny.expose.examples.unique.UniqueExperiment bubble --verbose, you get the following message:$ Sorry, that is not a valid "Unique" algorithm.This checking was implemented in main methods of SortingExperiment.java and UniqueExperiment.java. It may be good to update the README so that other extensions of the DoubleExperiment class may also include this checking.