This repository was archived by the owner on Sep 30, 2025. It is now read-only.
Don't overflow on ByteAggregator creation#23
Open
jazcarate wants to merge 1 commit intoking:masterfrom
Open
Conversation
cvielma
reviewed
Oct 14, 2022
| import org.junit.jupiter.api.Test; | ||
|
|
||
| import static org.junit.jupiter.api.Assertions.assertNotNull; | ||
| import static org.junit.jupiter.api.Assertions.*; |
There was a problem hiding this comment.
style: we typically prefer explicit imports.
cvielma
approved these changes
Oct 14, 2022
Codecov ReportBase: 79.97% // Head: 79.93% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #23 +/- ##
============================================
- Coverage 79.97% 79.93% -0.05%
+ Complexity 973 972 -1
============================================
Files 118 118
Lines 3491 3493 +2
Branches 322 322
============================================
Hits 2792 2792
- Misses 527 528 +1
- Partials 172 173 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…derlying ByteArrayOutputStream. Bonus: Fix warnings on the `ByteAggregatorTest`
jazcarate
force-pushed
the
bugfix/byteaggregator-overflow
branch
from
335afe8 to
a063e18
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
intfor the ByteAggregator to not overflow when creating the underlying ByteArrayOutputStream.Bonus: Fix warnings on the
ByteAggregatorTest