Conversation
yaleman
left a comment
There was a problem hiding this comment.
I like things that fix other things 🥳
Is it pushed? I can't see it...
For some reason, I can't reproduce it on my current VMs with or without the changes (but I'll try more). Good news that @vashirov was able to hit it before! I provided the prepped build for the env, so hopefully soon we'll share how it went. And thanks for such a fast investigation/fix response! I really appreciate it! |
My mistake! Pushed now.
Sounds good, let me know how it goes :) |
|
Hey @Firstyear, I ran my reproducer for hours and it didn't crash with this fix. Thanks! :) |
droideck
left a comment
There was a problem hiding this comment.
My testing was also not able to hit any panics. Ack from me too!
After a whole day of testing, debugging, logging, I have found the problem @droideck - the haunted lists were being incorrectly cleared which then left dangling pointers in the cache.
This resolves the issue, does a bit of linked list tidy up, adds a ton of assertions, and resolves the issue.
Hope that helps!
#Fixes #149