Skip to content

Conversation

@joanfont
Copy link

No description provided.

@joanfont
Copy link
Author

joanfont commented Sep 5, 2016

@kaime ping

@kaime
Copy link
Owner

kaime commented Sep 5, 2016

Hey, @joanfont, person I have never met! Thank you so much for this contribution. Thanks for helping make the world a better place, for you and for me and the entire human race. There are people dying, you knew?

This could be a very nice feature to ship with the 0.2.0 release. But first, let me take a look at the PR. I need to QA it in order to keep this an enterprise-level dick generator.

Bt the way. You should agree to release your code under the terms of the WTFPL. Is that ok with you?

}

LENGTH=5
read -t 0.01 STDIN_LENGTH
Copy link
Owner

@kaime kaime Sep 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need the timeout? Just tested without and tests passed smoothly on Ubuntu Xenial. Are you by any chance using an evil OS?

@kaime
Copy link
Owner

kaime commented Sep 5, 2016

We also need to update the docs. I can do it for you when the PR is ready to be merged.

@kaime kaime added this to the 0.2.0 milestone Sep 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants