[JS] Remove extra files from package #138
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the package smaller.
Fix CI issues:
rust-lang/rust#131477
The PR doesn't directly mention undefined N-API symbols. But the fact that the runner image updated Rust from 1.90 to 1.91,
and that's when the linking failures started, is compelling evidence. The fix I added (the -undefined dynamic_lookup flags) is
the correct solution regardless - it's been the standard approach for N-API addons on macOS for years.
Why the linker flags are now needed:
successful build) to 20251104.0104 (used in Nov 7 failed builds)
cc, and pass it viaSDKROOTenv var rust-lang/rust#131477 via the SDKROOT environmentvariable. This appears to have made the linker stricter about undefined symbols in cdylibs.
as these symbols are intentionally undefined and resolved at runtime by Node.js. The flags tell the macOS linker to allow
these undefined symbols.