Skip to content

fix: handle escaped backslashes correctly when parsing JSON strings #2022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SaiChaii wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: handle escaped backslashes correctly when parsing JSON strings #2022

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 24 additions & 5 deletions lib/getPartsOfJson.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,21 @@ const regexNumber = /^\s*(?<number>-?\d+(\.\d+)?([Ee][+-]?\d+)?)\s*$/g;
const regexString = /^\s*(?<string>"(\\"|[^"])*")\s*$/g;
const regexBoolean = /^\s*(?<boolean>true|false)\s*$/g;
const regexNull = /^\s*(?<null>null)\s*$/g;
const regexDoubleQuote = /(?<!\\)"/g;
// const regexDoubleQuote = /(?<!\\)"/g;
const regexCommaOrEndOfLine = /,/g;

const isEscapedQuote = (str: string, quoteIndex: number) => {
let backslashCount = 0;
let i = quoteIndex - 1;

while (i >= 0 && str[i] === '\\') {
backslashCount++;
i--;
}

return backslashCount % 2 === 1;
};

export type SyntaxPart = {
type: string;
address?: string;
Expand Down Expand Up @@ -188,10 +200,17 @@ const getPartsOfJsonObjectContent = (
offset = 0,
jsonPath: string,
): SyntaxPart[] => {
const doubleQuoteMatches = getFindResultsByGlobalRegExp(
serializedJson,
regexDoubleQuote,
);
const doubleQuoteMatches: RegExpResult[] = [];

for (let i = 0; i < serializedJson.length; i++) {
if (serializedJson[i] === '"' && !isEscapedQuote(serializedJson, i)) {
doubleQuoteMatches.push({
index: i,
match: '"',
groups: [],
});
}
}
let keywordStartIndex = 0;
let stringsWithPayload: StringWithPayload[] = [];
doubleQuoteMatches.forEach((doubleQuoteMatch, index) => {
Expand Down
Loading