Fix navigation when value is outside allowed range#1084
Open
josalmi wants to merge 1 commit intojquense:v4-stablefrom
Open
Fix navigation when value is outside allowed range#1084josalmi wants to merge 1 commit intojquense:v4-stablefrom
josalmi wants to merge 1 commit intojquense:v4-stablefrom
Conversation
React widgets v5 example below where this is also an issue:
```
<DatePicker
min={new Date(2021,10,30)}
defaultValue={new Date(2021, 5, 20)}
/>;
```
We are however using V4 and its time picker and would appreciate if this can get patched there as well without having to create a fork.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
React widgets v5 example below where this is also an issue:
We are however using V4 and its time picker and would appreciate if this can get patched there as well without having to create a fork. In short, when value is outside the range of
minandmax, you cannot navigate to other months until the value is within the range. The check inside componentDidMount will always fail and set current date back to to theminormax.I believe this code was somewhat ported to V5 here: https://github.com/jquense/react-widgets/blob/master/packages/react-widgets/src/Calendar.tsx#L377-L385 and a similar change would suffice.