Skip to content

Keep the array order even if nickname exists #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vladan-me wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Keep the array order even if nickname exists #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion parser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ public function parse_name($full_name) {
$has_nick = $this->get_nickname($full_name);
if ($has_nick) {
# Remove wrapper chars from around nickname
$name['nickname'] = mb_substr($has_nick, 1, (mb_strlen($has_nick) - 2));
$nickname = mb_substr($has_nick, 1, (mb_strlen($has_nick) - 2));
# Remove the nickname from the full name
$full_name = str_replace($has_nick, '', $full_name);
# Get rid of consecutive spaces left by the removal
Expand Down Expand Up @@ -297,6 +297,7 @@ public function parse_name($full_name) {
$name['lname_base'] = trim($lname_base);
$name['lname_compound'] = trim($lname_compound);
$name['suffix'] = $suffix;
$name['nickname'] = isset($nickname) ? trim($nickname) : '';
return $name;
}

Expand Down