SendWithConn()#80
Open
BourgeoisBear wants to merge 1 commit intojordan-wright:masterfrom
BourgeoisBear:master
Open
SendWithConn()#80BourgeoisBear wants to merge 1 commit intojordan-wright:masterfrom BourgeoisBear:master
BourgeoisBear wants to merge 1 commit intojordan-wright:masterfrom
BourgeoisBear:master
Conversation
(*Email) ParsedAddresses() receiver function to ensure consistent parsing across Send... functions
jordan-wright
requested changes
Feb 18, 2019
Owner
jordan-wright
left a comment
jordan-wright
left a comment
There was a problem hiding this comment.
Hi @BourgeoisBear,
Thanks for sending this in! This seems reasonable to me, I've just left a small nitpick about the parameter names to help match the style with the rest of the library.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wanted to set an IO deadline, and force SSL from square-one, so I added this.