Streaming attachments instead of their fetching into buffers#157
Open
YuriiRubakha wants to merge 9 commits intojordan-wright:masterfrom
Open
Streaming attachments instead of their fetching into buffers#157YuriiRubakha wants to merge 9 commits intojordan-wright:masterfrom
YuriiRubakha wants to merge 9 commits intojordan-wright:masterfrom
Conversation
Co-authored-by: Francisco Delmar Kurpiel <francisco.kurpiel@simplesurance.de>
Co-authored-by: Fabian Holler <mail@fholler.de>
…-new' into CORE-10934-attachments-streaming-new
…ming-new [CORE-10934]-Redusing-memory-attachments-streaming
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some use cases attachment data is streamed from external source. Fetching this data into buffers causes additional memory consumption, which may be significant for massive emails sending.
To solve this we propose to stream attachments data directly from readers, as they provided by external interface of package (no external interface change).
Internal structures changed accordingly. Some tests changed also to match the new Attachment struct.
No significant negative impact on performance.