#147 Proper handling of utf-8 characters in reply-to headers#148
Closed
tarmo-randma wants to merge 10 commits intojordan-wright:masterfrom
Closed
#147 Proper handling of utf-8 characters in reply-to headers#148tarmo-randma wants to merge 10 commits intojordan-wright:masterfrom
tarmo-randma wants to merge 10 commits intojordan-wright:masterfrom
Conversation
raliqala
approved these changes
Jan 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to resolve #147.
Most e-mail headers got proper character encoding handling with PR #132. Unfortunately that change missed that the reply-to header was not treated as an address but as a regular header. As a result it did not get the same kind of handling as the from, to, cc and bcc headers.
This PR extends the same functionality also to the Reply-To header. It also adds corresponding tests and updates the project github workflow to work with Go 1.16 even without a go.mod file