issue #149 - updated serialize branch, even on drag#152
issue #149 - updated serialize branch, even on drag#152maikelmclauflin wants to merge 1 commit intojohnny:masterfrom maikelmclauflin:feature/update_serialize
Conversation
|
This makes dragging more expensive. What is the reason for this change? Perhaps we can find less CPU intensive way to do it. |
|
The reason for this change is to have an updated tree on drag. Without this feature, if a serialize is called the tree that is returned is the tree that is started with, before drag. What part of this is cpu intensive? There is no dom querying, since all of the elements are already in memory. Are you seeing any lag? |
|
I have the feeling that this use case is very unique and I therefore hesitate to merge this. Why do you need to serialize during drag? One way to solve your problem would be to add custom data attributes to the placeholder and the dragged item. In a post processing step you could then replace the serialized placeholder (identified by the custom data attribute) with the serialized dragged item Edit: actually, I don't know if the placeholder is serialized. Is it? Another way to solve this would be to override the afterMove method to save the current location of the placeholder. |
No description provided.