Skip to content

fix: Could not parse GitHub owner/repo name from AWS CodeBuild project #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jeremywaller wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: Could not parse GitHub owner/repo name from AWS CodeBuild project #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c3b703
fix regex parsing
jeremywaller Nov 9, 2021
b7ab099
test update
jeremywaller Nov 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/github_proxy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ def _init_github_info(self):
' parameter to specify a token to use when writing to GitHub.'.format(config.PROJECT_NAME))

github_location = project_details['source']['location']
matches = re.search(r'github\.com\/(.+)\/(.+)\.git$', github_location)
matches = re.search(r'github\.com\/(.+)\/(.+)$', github_location)
if not matches:
raise RuntimeError(
'Could not parse GitHub owner/repo name from AWS CodeBuild project {}. location={}'.format(
Expand Down
2 changes: 1 addition & 1 deletion test/unit/test_github_proxy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

GITHUB_OWNER = 'gh-user'
GITHUB_REPO = 'gh-repo'
GITHUB_LOCATION = 'https://github.com/{}/{}.git'.format(GITHUB_OWNER, GITHUB_REPO)
GITHUB_LOCATION = 'https://github.com/{}/{}'.format(GITHUB_OWNER, GITHUB_REPO)
CODEBUILD_GITHUB_TOKEN = 'shhh!!'
SECRETS_MANAGER_GITHUB_TOKEN = "don't tell!!"
BUILD_STATUS = 'SUCCEEDED'
Expand Down