Skip to content

Add typing #974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jieter wants to merge 39 commits into
base: master
Choose a base branch
from
+568 −395
Open

Add typing #974

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
6089eeb
some typing
jieter Nov 6, 2024
c32d6cb
more
jieter Nov 6, 2024
fdc4dcd
More typing, remove RelatedLinkColumn
jieter Nov 6, 2024
cda13e2
more
jieter Nov 6, 2024
7b0254d
Paginator typing
jieter Nov 6, 2024
88f7317
Use a python 3.9-friendly union type syntax
jieter Dec 21, 2024
e7ef9c6
More typing
jieter Dec 21, 2024
3dbd165
More typing
jieter Dec 21, 2024
eee0524
Even more typing and removing iter methods on BoundColumns
jieter Dec 21, 2024
0f7e5be
Export typing
jieter Dec 21, 2024
7d3f81a
Down to 'Found 51 errors in 12 files (checked 27 source files)'
jieter Dec 21, 2024
c370e24
Current state: Found 20 errors in 10 files (checked 27 source files)
jieter Dec 21, 2024
ffed229
Some more typing
jieter Dec 22, 2024
555071a
Add typing for cell arguments
jieter Dec 23, 2024
653cff9
Merge
jieter Nov 15, 2025
083f5a2
More types
jieter Nov 15, 2025
3a5f245
Fix runtime crash
jieter Nov 15, 2025
4e474af
Fix tests
jieter Nov 15, 2025
c11a580
try fix pre-commit mypy complaints
jieter Nov 15, 2025
22ab0d5
try fix pre-commit mypy complaints
jieter Nov 15, 2025
4d2178d
try fix pre-commit mypy complaints
jieter Nov 15, 2025
222a6ca
Upgrade mypy in pre-commit config
jieter Nov 15, 2025
df8dd39
Another try
jieter Nov 15, 2025
42e494e
Another try
jieter Nov 15, 2025
d86859b
Fix all mypy errors?
jieter Nov 15, 2025
8ef885b
Attempt to improve typing
jieter Nov 21, 2025
d4f53e3
Attempt number 20
jieter Nov 22, 2025
8200580
Merge remote-tracking branch 'origin/master' into feature/util-typing
jieter Nov 22, 2025
ef700b7
Merge remote-tracking branch 'origin/master' into feature/util-typing
jieter Nov 22, 2025
3ee352c
unpack not a runtime import
jieter Nov 22, 2025
ab7e3a6
one more not runtime unpack
jieter Nov 22, 2025
d05e43d
revert isinstance change triggered by UP038
jieter Nov 22, 2025
762215d
Merge remote-tracking branch 'origin/master' into feature/util-typing
jieter Nov 22, 2025
0e7a537
Return type for Library.register()
jieter Nov 22, 2025
c715a2d
Improve typing more
jieter Nov 22, 2025
f01f808
more typing
jieter Nov 24, 2025
1960421
Fix runtime test errors
jieter Nov 24, 2025
7f43a8c
mypy is satisfied again
jieter Nov 24, 2025
710887d
Small steps
jieter Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,9 @@ repos:
- id: django-upgrade
args: [--target-version, "4.2"]

- repo: https://github.com/pre-commit/mirrors-mypy
rev: v1.18.2
hooks:
- id: mypy
args: ["--explicit-package-bases", "django_tables2"]
pass_filenames: false
Loading
Loading