Defer connection until a request is made, and reconnect when necessary#49
Open
luke-jr wants to merge 1 commit intojgarzik:masterfrom
Open
Defer connection until a request is made, and reconnect when necessary#49luke-jr wants to merge 1 commit intojgarzik:masterfrom
luke-jr wants to merge 1 commit intojgarzik:masterfrom
Conversation
Since 02d6ed6, any problem with the connection has been permanently fatal to all future requests. This solves that with a new SharedConnection class that recreates the internal http.client connection as needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 02d6ed6, any problem with the connection has been permanently fatal to all future requests.
This solves that with a new SharedConnection class that recreates the internal http.client connection as needed.