XRAY-132834 - Add an example for catalog to use caching with valkey #2157
Conversation
| password: "your-custom-password" | ||
| ``` | ||
|
|
||
| ## Deployment |
There was a problem hiding this comment.
The readme tells the user how to deploy, but not how to verify that Valkey is actually running or that Catalog is connecting to it. After deployment, please add the Verification section towards the end.
| global: | ||
| valkey: | ||
| password: "your-custom-password" | ||
| ``` |
There was a problem hiding this comment.
add a note
For production environments, avoid hardcoding passwords in plain text. Use Kubernetes Secrets or an external secrets manager.
There was a problem hiding this comment.
@nagarajuv-jfrog
Currently, we do not support Valkey passwords as secrets. This is a feature request that needs to be taken up.
rahulsadanandan
force-pushed
the
feature/XRAY-132834
branch
from
fbaa775 to
cf27f6e
Compare
|
|
||
| This example shows how to deploy JFrog Xray with Catalog using Valkey for caching. Valkey is an open-source, in-memory data structure store that acts as a cache to improve performance. | ||
|
|
||
| ## What is Valkey? |
There was a problem hiding this comment.
You are not describing what Valkey is. Just explaining how it's deployed. I suggest adjusting the title of this section.
There was a problem hiding this comment.
Changed now..
rahulsadanandan
force-pushed
the
feature/XRAY-132834
branch
from
cf27f6e to
1e95cf3
Compare
PR Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[artifactory])What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: