feat(ci): GitHub action for pull requests#24
Conversation
timothystewart6
force-pushed
the
github-actions-pull-request
branch
from
b9e74e0 to
61db806
Compare
|
You can see this in action on my fork: https://github.com/timothystewart6/cloud-api/actions/runs/13469922327/job/37642166583?pr=3 |
|
Looks great! We'll likely need to change it to use the BuildJet runners, but I assume Adam or Lian will need to do that. |
|
@Nevexo Thanks! I am unsure why it would take specialized runners considering it's just a NodeJS app and I have already been building this container on my fork without any issues. |
Because BulildJet make the JetKVM 😉 |
Got it, I assume you mean the native piece or something else? Public runners like this would work just fine I assume as you can see above. The container is already built on my fork and is publicly accessible through GitHub. Not sure why it would take specialized, private runners to do this but maybe I am missing something 😅 |
|
any movement on this? or explanation on why it can't use default github runners? @Nevexo |
I have no updates on it, it's out of my control - there's no reason why it can't run on public runners, but since it's a BuildJet product they'll probably want to use their own runners lol |
|
We could bump to actions/checkout@v5 |
| - name: Use Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: v21.1.0 |
There was a problem hiding this comment.
This should be "22" to match what we do over in the kvm repo
5 participants
A simple action for pull requests that installs dependencies, transpiles TypeScript to JavaScript, and generates schemas on every pull request. Ideally this would be a great place for linting and tests however neither have bee adopted.
Depends on #22