Skip to content

Conversation

@jonesbusy
Copy link

Hello ssh-slaves developers! 👋

This is an automated pull request created by the Jenkins Plugin Modernizer tool. The tool has applied the following recipes to modernize the plugin:

Migrate Commons Lang from 2 to 3 and StringEscapeUtils to Commons Text

io.jenkins.tools.pluginmodernizer.MigrateCommonsLang2ToLang3AndCommonText

Migrate Commons Lang from 2 to 3 and StringEscapeUtils to Commons Text.

This pull request upgrades Apache Commons Lang 2 to Apache Commons Lang 3. Additionally, if the plugin uses StringEscapeUtils from Apache Commons Lang, it will be migrated to use Apache Commons Text instead.
The Apache Commons community recommends using Apache Commons Text for string escaping operations, as it offers a more focused and feature-rich API for text processing.

What's Changed?

  • Migrated from deprecated/EOL Apache Commons Lang 2 to Commons Lang 3.
  • If applicable: Transitioned from deprecated/EOL StringEscapeUtils in Apache Commons Lang to Commons Text.

@jonesbusy jonesbusy requested a review from a team as a code owner January 15, 2026 14:35
Copilot AI review requested due to automatic review settings January 15, 2026 14:35
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request migrates the ssh-slaves plugin from the deprecated Apache Commons Lang 2 to Apache Commons Lang 3. The migration is comprehensive and correctly updates all necessary imports and dependencies.

Changes:

  • Updated all Java import statements from org.apache.commons.lang to org.apache.commons.lang3
  • Added commons-lang3-api dependency to the POM
  • Upgraded parent POM version to support Commons Lang 3 and enforce the ban on Commons Lang 2

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pom.xml Added commons-lang3-api dependency, upgraded parent POM to version 6.2116, and enabled ban-commons-lang-2 enforcer rule
src/main/java/hudson/plugins/sshslaves/SSHLauncher.java Updated StringUtils import from commons-lang to commons-lang3
src/main/java/hudson/plugins/sshslaves/SSHConnector.java Updated StringUtils import from commons-lang to commons-lang3
src/main/java/hudson/plugins/sshslaves/verifiers/KnownHostsFileKeyVerificationStrategy.java Updated StringUtils import from commons-lang to commons-lang3
src/test/java/hudson/plugins/sshslaves/agents/AgentConnectionBaseTest.java Updated SystemUtils import from commons-lang to commons-lang3

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant