-
Notifications
You must be signed in to change notification settings - Fork 18
chore(deps): update dependency webpack to v5.94.0 [security] #261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
renovate
wants to merge
1
commit into
master
Choose a base branch
from
renovate/npm-webpack-vulnerability
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a8f90e8 to
a04570d
Compare
c5e4d40 to
1a65d5b
Compare
1a65d5b to
737dae1
Compare
737dae1 to
daf40f6
Compare
3df8a80 to
2fe8170
Compare
775e39f to
eb65bbf
Compare
eb65bbf to
abed7ea
Compare
abed7ea to
2ee43a3
Compare
2ee43a3 to
a874e0d
Compare
a874e0d to
f5d036e
Compare
f5d036e to
e8546ad
Compare
e8546ad to
71c233d
Compare
218db0b to
af69d3b
Compare
af69d3b to
19fdd38
Compare
19fdd38 to
ce881a8
Compare
ce881a8 to
3658819
Compare
3658819 to
1146292
Compare
1146292 to
26547a7
Compare
26547a7 to
50d2c1f
Compare
50d2c1f to
55c0035
Compare
55c0035 to
3eef15c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
5.82.0→5.94.0GitHub Vulnerability Alerts
CVE-2024-43788
Summary
We discovered a DOM Clobbering vulnerability in Webpack’s
AutoPublicPathRuntimeModule. The DOM Clobbering gadget in the module can lead to cross-site scripting (XSS) in web pages where scriptless attacker-controlled HTML elements (e.g., animgtag with an unsanitizednameattribute) are present.We found the real-world exploitation of this gadget in the Canvas LMS which allows XSS attack happens through an javascript code compiled by Webpack (the vulnerable part is from Webpack). We believe this is a severe issue. If Webpack’s code is not resilient to DOM Clobbering attacks, it could lead to significant security vulnerabilities in any web application using Webpack-compiled code.
Details
Backgrounds
DOM Clobbering is a type of code-reuse attack where the attacker first embeds a piece of non-script, seemingly benign HTML markups in the webpage (e.g. through a post or comment) and leverages the gadgets (pieces of js code) living in the existing javascript code to transform it into executable code. More for information about DOM Clobbering, here are some references:
[1] https://scnps.co/papers/sp23_domclob.pdf
[2] https://research.securitum.com/xss-in-amp4email-dom-clobbering/
Gadgets found in Webpack
We identified a DOM Clobbering vulnerability in Webpack’s
AutoPublicPathRuntimeModule. When theoutput.publicPathfield in the configuration is not set or is set toauto, the following code is generated in the bundle to dynamically resolve and load additional JavaScript files:However, this code is vulnerable to a DOM Clobbering attack. The lookup on the line with
document.currentScriptcan be shadowed by an attacker, causing it to return an attacker-controlled HTML element instead of the current script element as intended. In such a scenario, thesrcattribute of the attacker-controlled element will be used as thescriptUrland assigned to__webpack_require__.p. If additional scripts are loaded from the server,__webpack_require__.pwill be used as the base URL, pointing to the attacker's domain. This could lead to arbitrary script loading from the attacker's server, resulting in severe security risks.PoC
Please note that we have identified a real-world exploitation of this vulnerability in the Canvas LMS. Once the issue has been patched, I am willing to share more details on the exploitation. For now, I’m providing a demo to illustrate the concept.
Consider a website developer with the following two scripts,
entry.jsandimport1.js, that are compiled using Webpack:The webpack.config.js is set up as follows:
When the developer builds these scripts into a bundle and adds it to a webpage, the page could load the
import1.jsfile from the attacker's domain,attacker.controlled.server. The attacker only needs to insert animgtag with thenameattribute set tocurrentScript. This can be done through a website's feature that allows users to embed certain script-less HTML (e.g., markdown renderers, web email clients, forums) or via an HTML injection vulnerability in third-party JavaScript loaded on the page.Impact
This vulnerability can lead to cross-site scripting (XSS) on websites that include Webpack-generated files and allow users to inject certain scriptless HTML tags with improperly sanitized name or id attributes.
Patch
A possible patch to this vulnerability could refer to the Google Closure project which makes itself resistant to DOM Clobbering attack: https://github.com/google/closure-library/blob/b312823ec5f84239ff1db7526f4a75cba0420a33/closure/goog/base.js#L174
Please note that if we do not receive a response from the development team within three months, we will disclose this vulnerability to the CVE agent.
Release Notes
webpack/webpack (webpack)
v5.94.0Compare Source
Bug Fixes
data/http/httpsprotocols in source mapsbigintoptimistic when browserslist not foundNew Features
webpackIgnorefornew URL()construction@importpathinfo supportSecurity
v5.93.0Compare Source
Bug Fixes
DefinePluginquieter under default log levelNew Features
binarygenerator option for asset modules to explicitly keep source maps produced by loadersmodern-modulelibrary value for tree shakable outputoverrideStrictoption to override strict or non-strict mode for javascript modulesv5.92.1Compare Source
Bug Fixes
v5.92.0Compare Source
Bug Fixes
subtractRuntimefunction for runtime logiccss/globaltype now handles the exports name@keyframeand@propertyat-rules incss/globaltypestats.hasWarnings()method now respects theignoreWarningsoptionArrayQueueiterator__webpack_exports_info__.a.b.canMangleCommonJsChunkFormatPluginpluginchunkLoadingoption to theimportwhen environment is unknown and output is modulemodulechunkFormat usedcssmodule type should not allow parser to switch modeNew Features
import attributesspec (withkeyword)node:prefix for Node.js core modules in runtime codeimportsFieldsoption for resolverInitFragmentclass for pluginscompileBooleanMatcherutil for pluginsInputFileSystemandOutputFileSystemtypesesModulegenerator option for CSS modulesv5.91.0Compare Source
Bug Fixes
unsafeCacheoption to be a proxy objectsnapshot.unmanagedPathsoptionfstypeslayer/supports/mediafor external CSS importsNew Features
__webpack_nonce__for CSS chunksfetchPriorityfor CSS chunksproductionmode by default)v5.90.3Compare Source
Bug Fixes
Stats.toJson()andStats.toString()Perf
v5.90.2Compare Source
Bug Fixes
Math.imulinfnv1a32to avoid loss of precision, directly hash UTF16 valuessetStatus()of the HMR module should not return an array, which may cause infinite recursion__webpack_exports_info__.xxx.canMangleshouldn't always same as defaultactiveStatetry/catchDependencies & Maintenance
v5.90.1Compare Source
Bug Fixes
unmanagedPathsin defaultspreOrderIndexandpostOrderIndexPerformance
compareStringsNumericnumberHashusing 32-bit FNV1a for small ranges, 64-bit for largerv5.90.0Compare Source
Bug Fixes
RemoveParentModulesPluginvia bigint arithmeticServerandDirentfetchPriorityto hmr runtime'sensureChunkfunctionoutput.environment.arrowFunctionoption/*#__PURE__*/to generatedJSON.parse()amdexternals andamdlibrarySideEffectsFlagPluginwith namespace re-exportsorstrictModuleErrorHandlingis now workingNew Features
falsefor dev server inwebpack.config.jsnode-moduleoption for thenode.__filename/__dirnameand enable it by default for ESM targetsnapshot.unmanagedPathsoptionMultiCompilerOptionstypeexportsOnlyoption to CSS generator optionsDependencies & Maintenance
Full Changelog: webpack/webpack@v5.89.0...v5.90.0
v5.89.0Compare Source
New Features
Dependencies & Maintenance
Full Changelog: webpack/webpack@v5.88.2...v5.89.0
v5.88.2Compare Source
Bug Fixes
Full Changelog: webpack/webpack@v5.88.1...v5.88.2
v5.88.1Compare Source
Developer Experience
Full Changelog: webpack/webpack@v5.88.0...v5.88.1
v5.88.0Compare Source
New Features
css/autoas the default css mode by @burhanuday in #17399Bug Fixes
Developer Experience
Dependencies & Maintenance
New Contributors
Full Changelog: webpack/webpack@v5.87.0...v5.88.0
v5.87.0Compare Source
New Features
fetchPriorityfeature as parser option and magic comment by @alexander-akait in #17249Bug Fixes
Developer Experience
Dependencies & Maintenance
New Contributors
@aboktor made their first contribution in #16991 #16989
@silverwind made their first contribution in #17339 via #17329
Full Changelog: webpack/webpack@v5.86.0...v5.87.0
v5.86.0Compare Source
New Features
ProgressPluginby @alexander-akait in #17312RegExptosplitChunks.chunksby @hyf0 in #17332Bug Fixes
ContextModuletypes by @huozhi in #17310__non_webpack_require__with ES modules by @alexander-akait in #17308Chunk,ChunkGroup, and other plugins by @alexander-akait in #1731jsextension for eval source maps when extension is not resolvable by @alexander-akait in #17331Developer Experience
Dependencies & Maintenance
New Contributors
Full Changelog: webpack/webpack@v5.85.1...v5.86.0
v5.85.1Compare Source
Bug Fixes
BasicEvaluatedExpression.getMemberRangeStartshas been changed toBasicEvaluatedExpression.getMemberRanges, please see type definition changes and the pull request for more information.Dependencies & Maintenance
Full Changelog: webpack/webpack@v5.85.0...v5.85.1
v5.85.0Compare Source
New Features
readonlycache mode by @vankop in #15470environmentin loader context by @alexander-akait in #17281addModule()support in worklets -*context.audioWorklet.addModule()by @alexander-akait in #17212Bug Fixes
Developer Experience
Dependencies & Maintenance
Full Changelog: webpack/webpack@v5.84.1...v5.85.0
v5.84.1Compare Source
Bug Fixes
Dependencies & Maintenance
Full Changelog: webpack/webpack@v5.84.0...v5.84.1
v5.84.0Compare Source
New Features
appendoption as a function by @snitin315 in #17252Bug Fixes
@importby @alexander-akait in #17229Developer Experience
JavascriptParserandModuleDependencysubclasses by @alexander-akait in #17236strict-mode quality for Configuration/Normalization objects by @alexander-akait in #17247with { type: "json" }by @alexander-akait in #17230Dependencies & Maintenance
New Contributors
Full Changelog: webpack/webpack@v5.83.1...v5.84.0
v5.83.1Compare Source
Bug Fixes
Full Changelog: webpack/webpack@v5.83.0...v5.83.1
v5.83.0Compare Source
New Features
Bug Fixes
chunkgroup.groupsIterablereturn type by @TheLarkInn in #17196Developer Experience
ChunkGroupto type definitions by @TheLarkInn in #17201NormalModuleFactory'sResolveDatatype to public interface by @TheLarkInn in #17195compilation.afterChunkshook by @TheLarkInn in #17202Dependencies & Maintenance
New Contributors
Full Changelog: webpack/webpack@v5.82.1...v5.83.0
v5.82.1Compare Source
Bug Fixes
importModulewhen CSS enabled by @alexander-akait in #17140output.hashFunctionwas failing to generate debug hash by @ahabhgk in #16950Developer Experience
Dependencies & Maintenance
New Contributors
Full Changelog: webpack/webpack@v5.82.0...v5.82.1
Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.