multiplots with patchwork #100
Conversation
| hideYAxisLabels = density, | ||
| hideXAxisName = FALSE, | ||
| hideYAxisName = FALSE, | ||
| xBreaks = NULL |
There was a problem hiding this comment.
@Kucharssim any idea why you added this in the past, and if this is an appropriate name for it? I realize it's been a while 😅
There was a problem hiding this comment.
do you mean only xBreaks or the other arguments in general?
the xBreaks were added so that we can pass the same breaks into different plotting functions in the matrix or bivariate with margins plots. I do not remember about the rest of the args but I can try to read the code a bit more and remember.
but, iirc, I wasn't happy with the jaspHistogram changes I did there to make it work with the jaspMatrixPlot, that's why there's also the new jaspMarginal functionality. Specifically, I think ideally we would use only the jaspMarginal, jaspBivariate, jaspBivariateWithMargins, and jaspMatrixPlot together and revert the changes to jaspHistogram, so that analyses that already used jaspHistogram will still work normally. But I think the jaspMarginal is not fully working so there's still some work to be done there 🥲
2 participants
@Kucharssim this is an attempt to revive #72
I left the code mostly as is, except for the stuff I commented on below. I still need to test if the changes to jaspHistogram result in breaking changes for the unit tests.