feat: Move git command to a subcommand of bump.#7
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reorganizes the git command by moving it as a subcommand under the bump command while retaining the old git command as a deprecated command on the root.
- Migrate the git command to be accessed via bumpCmd
- Introduce a deprecated git command on the root and add new tests for tag retrieval functionality
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cmd/root.go | Added subcommands for deprecatedGitCmd, bumpCmd, and SortCmd. |
| cmd/git_test.go | Introduced tests for getTagsStrings with valid and empty tag cases. |
| cmd/git.go | Created a deprecatedGitCmd and updated flag initialization. |
| cmd/bump.go | Updated the command hierarchy to register gitCmd under bumpCmd. |
Comments suppressed due to low confidence (1)
cmd/git_test.go:134
- [nitpick] Consider renaming test functions to follow standard Go naming conventions (e.g., TestGetTagsStringsValidVersions) for improved readability.
func Test_GetTagsStrings_ValidVersions(t *testing.T) {
4e0aa31 to
8b8e306
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.