-
Notifications
You must be signed in to change notification settings - Fork 2
Improve icons #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve icons #46
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates icons across the action menu components and refactors preview implementations. The changes primarily focus on renaming variables for clarity, consolidating preview components, updating dependencies, and improving icon spacing in overflow menus.
Changes:
- Renamed "use location" references to "sample checkbox" and updated associated icons (AccountBox, Create)
- Consolidated Android-specific preview files into multiplatform commonMain implementations
- Updated dependencies including maven-publish plugin and moved UI tooling to commonMain
- Enhanced overflow menu item spacing and icon alignment with conditional padding
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sample-app/src/main/res/values/strings.xml | Updated string resource from "use_location" to "sample_checkbox" |
| sample-app/src/main/kotlin/nl/jacobras/composeactionmenu/sample/MainActivity.kt | Renamed variables and updated icons to AccountBox and Create |
| gradle/libs.versions.toml | Added compose-uiTooling dependency and upgraded maven-publish plugin |
| compose-action-menu/src/commonMain/kotlin/nl/jacobras/composeactionmenu/PreviewAnnotations.kt | Updated imports to use AndroidUiModes instead of Configuration constants |
| compose-action-menu/src/commonMain/kotlin/nl/jacobras/composeactionmenu/OverflowActionItem.kt | Added conditional icon padding, moved previews from androidMain, and improved spacing |
| compose-action-menu/src/commonMain/kotlin/nl/jacobras/composeactionmenu/IconActionItem.kt | Added documentation and moved previews from androidMain |
| compose-action-menu/src/commonMain/kotlin/nl/jacobras/composeactionmenu/ActionMenu.kt | Added addPaddingIfNoIcon parameter to control overflow menu alignment |
| compose-action-menu/src/androidMain/kotlin/nl/jacobras/composeactionmenu/OverflowActionItemPreviews.kt | File deleted (previews moved to commonMain) |
| compose-action-menu/src/androidMain/kotlin/nl/jacobras/composeactionmenu/IconActionItemPreviews.kt | File deleted (previews moved to commonMain) |
| compose-action-menu/build.gradle.kts | Updated dependencies to commonMain and removed unused imports/configurations |
| .github/workflows/publish.yml | Refactored to use centralized build-setup action |
| .github/workflows/build.yml | Refactored to use centralized build-setup action |
| .github/actions/build-setup/action.yml | New composite action for build environment setup |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
In this PR: