Skip to content

Conversation

@jacobras
Copy link
Owner

@jacobras jacobras commented Jan 22, 2026

In this PR:

image

@jacobras jacobras requested a review from Copilot January 22, 2026 19:21
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates icons across the action menu components and refactors preview implementations. The changes primarily focus on renaming variables for clarity, consolidating preview components, updating dependencies, and improving icon spacing in overflow menus.

Changes:

  • Renamed "use location" references to "sample checkbox" and updated associated icons (AccountBox, Create)
  • Consolidated Android-specific preview files into multiplatform commonMain implementations
  • Updated dependencies including maven-publish plugin and moved UI tooling to commonMain
  • Enhanced overflow menu item spacing and icon alignment with conditional padding

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
sample-app/src/main/res/values/strings.xml Updated string resource from "use_location" to "sample_checkbox"
sample-app/src/main/kotlin/nl/jacobras/composeactionmenu/sample/MainActivity.kt Renamed variables and updated icons to AccountBox and Create
gradle/libs.versions.toml Added compose-uiTooling dependency and upgraded maven-publish plugin
compose-action-menu/src/commonMain/kotlin/nl/jacobras/composeactionmenu/PreviewAnnotations.kt Updated imports to use AndroidUiModes instead of Configuration constants
compose-action-menu/src/commonMain/kotlin/nl/jacobras/composeactionmenu/OverflowActionItem.kt Added conditional icon padding, moved previews from androidMain, and improved spacing
compose-action-menu/src/commonMain/kotlin/nl/jacobras/composeactionmenu/IconActionItem.kt Added documentation and moved previews from androidMain
compose-action-menu/src/commonMain/kotlin/nl/jacobras/composeactionmenu/ActionMenu.kt Added addPaddingIfNoIcon parameter to control overflow menu alignment
compose-action-menu/src/androidMain/kotlin/nl/jacobras/composeactionmenu/OverflowActionItemPreviews.kt File deleted (previews moved to commonMain)
compose-action-menu/src/androidMain/kotlin/nl/jacobras/composeactionmenu/IconActionItemPreviews.kt File deleted (previews moved to commonMain)
compose-action-menu/build.gradle.kts Updated dependencies to commonMain and removed unused imports/configurations
.github/workflows/publish.yml Refactored to use centralized build-setup action
.github/workflows/build.yml Refactored to use centralized build-setup action
.github/actions/build-setup/action.yml New composite action for build environment setup

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jacobras jacobras merged commit 0432257 into main Jan 22, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant