Conversation
{{cookiecutter.repo_name}}/Pipfile
Outdated
|
|
||
| [packages] | ||
| django = "<2.2" | ||
| django = "<=3.1" |
There was a problem hiding this comment.
shouldn't this be something more like ~3.1 or <3.2? This prevents those micro fixes from getting pulled in.
| |_____|_____/|______| |______|_| |_|\__, |_|_| |_|\___|\___|_| |_|_| |_|\__, | | ||
| __/ | __/ | | ||
| |___/ |___/ | ||
| Made with <3 in DC by https://isl.co |
|
We should really add some tests to make sure this works before merging 🤷 |
| @@ -1,3 +1,3 @@ | |||
| web: PYTHONUNBUFFERED=True python manage.py runserver 0.0.0.0:$PORT | |||
| static: npm run dev | |||
| rqworker: PYTHONUNBUFFERED=True python manage.py rqworkers high default low --autoreload | |||
There was a problem hiding this comment.
oh no! you removed django-rqworker. I suppose it probably doesn't work with django 4.0 (I'm not sure it worked with 2 or 3 either)
There was a problem hiding this comment.
@joesolly I forgot I had this PR open. I really was just updating my repo. Don't want to merge this in repo.... at least not yet.
But yeah RQ worker stopped working in 3.0 I think. Maybe we could get a few people together to see if there is any interests in fixing and maintaining. I know we talked about once.
There was a problem hiding this comment.
@CorneliusIV Maybe, unfortunately, I currently only work in celery or RMQ, so I don't have any work motivation to fix this. Hackathon? Pizza and Rosé?
2 participants
This should bump us up to Django 3.0
There is still an issue Django RQ Wrapper islco/django-rq-wrapper#7
I also killed our banner.txt
We might want to also look into updating the frontend dependencies.