Add network connectivity information to Server status
#562
Conversation
NetworkCheck indicates the network configuration validation status. Possible values: Unknown/Pass/Fail, default Unknown.
| // +kubebuilder:validation:Enum=Pass;Fail;Unknown | ||
| // +kubebuilder:default=Unknown | ||
| // +optional | ||
| NetworkCheck string `json:"networkCheck,omitempty"` |
There was a problem hiding this comment.
Who exactly should react on changes to that field? Also this looks like something which is better kept in the status.conditions.
There was a problem hiding this comment.
it's like a flag to check after buildup, reconfiguration. It will also be present in greenhouse/prometheus.
I agree that status.conditions is a better place.
There was a problem hiding this comment.
What we are doing on our side is setting lables/annotations indicating that the Server is ready for consumption.
There was a problem hiding this comment.
An idiomatic way of doing things like that would be e.g.:
Your controller which talks to netbox writes:
my-operator.io/network-validation-result: success
Then the ServerReconciler could populate e.g. the conditions slice with a corresponding Condition.
Alternatively we can define a dedicated substruct in the status for that e.g.:
status:
state: Available
conditions:
- type: Ready
# ... other fields ...
# Managed by some external component
networkConnectivity:
status: "Unknown" # "Ready", "Failure", "Checking"
lastUpdateTime: "2025-12-10T12:00:00Z"
message: "Awaiting connectivity check from external service."
The external component should have only PATCH RBAC permissions on the Server resources.
|
Can you please regenerate the Helm chart files via |
afritzler
changed the title
Server status
NetworkCheck indicates the network configuration validation status.
Possible values: Unknown/Pass/Fail, default Unknown.
Proposed Changes
networkCheckfield to theserverscrdFixes #
Allows an inventory check to compare the network definitions in netbox with the information in the crd and report on the outcome