-
-
Notifications
You must be signed in to change notification settings - Fork 0
Upgrade to Pycord 2.7.0 #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request upgrades the py-cord dependency from version 2.7.0rc2 (release candidate) to the stable 2.7.0 release. The upgrade includes refactoring the UI view classes to use a new base class architecture and replacing the stop() method pattern with a new ignore_interactions() pattern for better interaction control.
Changes:
- Upgraded py-cord from 2.7.0rc2 to 2.7.0 in requirements.txt
- Introduced
BaseViewandBaseGameViewbase classes withignore_interactions()mechanism - Replaced all instances of
stop()calls withignore_interactions()across UI views - Updated interaction handling in core.py to use the simplified
respond()method - Refactored view inheritance hierarchy to use new base classes
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| requirements.txt | Updated py-cord version from 2.7.0rc2 to stable 2.7.0 |
| eggsplode/ui/base.py | Added BaseView and BaseGameView classes with ignore_interactions mechanism |
| eggsplode/ui/init.py | Exported new BaseGameView class |
| eggsplode/ui/turn.py | Changed inheritance to BaseGameView and replaced stop() with ignore_interactions() |
| eggsplode/ui/start.py | Updated multiple view classes to use BaseView and ignore_interactions() pattern |
| eggsplode/ui/selections.py | Updated view classes to inherit from BaseView and use ignore_interactions() |
| eggsplode/ui/play.py | Changed to use BaseView and ignore_interactions() pattern |
| eggsplode/ui/nope.py | Changed inheritance to BaseGameView and replaced stop() calls |
| eggsplode/cards/skip.py | Replaced stop() calls with ignore_interactions() |
| eggsplode/core.py | Simplified interaction response handling using new respond() method |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 11 out of 12 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.