Use HTTPS by default and release v1.2.0#44
Use HTTPS by default and release v1.2.0#44slint wants to merge 3 commits intoinveniosoftware:masterfrom
Conversation
|
@lnielsen not sure if it should be v2.0.0 actually... One can see it as a "security fix", but on the other hand changing default parameters is breaking API... |
|
I think the issue with this one is that it's a pretty big "breaking change" to switch to HTTPS URL generation, affecting many other tests e.g. on RDM REST API responses and serialized formats. This means that we'll have to first check if we have upper pins for |
fenekku
left a comment
There was a problem hiding this comment.
It looks good to me.
My vote would be to make a ticket in invenio-app-rdm to
- cap idutils in previous versions of invenio-app-rdm and related modules if not already
- then release this
- then integrate the new version of idutils in invenio-app-rdm and related modules
For me: better security / up-to-date schemes trumps potential backward incompatibility / small breakage. And moving sooner rather than later is better. I don't have commit/release rights on this repo anyway though.

No description provided.