diff method doc string updates#137
Open
mikaelho wants to merge 9 commits intoinveniosoftware:masterfrom
Open
Conversation
jirikuncar
approved these changes
Jan 6, 2020
jirikuncar
reviewed
Jan 6, 2020
dictdiffer/__init__.py
Outdated
| - Key/value pairs for 'add' and 'remove'; keys for lists are indexes | ||
| - Previous/new values for 'change', key being a part of the path in this case | ||
| - Several value tuples sharing the same op and path are wrapped in a | ||
| list, unless you specify `expand=True`, in which case they all |
Member
There was a problem hiding this comment.
Suggested change
| list, unless you specify `expand=True`, in which case they all | |
| list, unless you specify `expand=True`, in which case they all |
jirikuncar
reviewed
Jan 6, 2020
| - Previous/new values for 'change', key being a part of the path in this case | ||
| - Several value tuples sharing the same op and path are wrapped in a | ||
| list, unless you specify `expand=True`, in which case they all | ||
| get a separate (op, path, values) tuple. |
Member
There was a problem hiding this comment.
Suggested change
| get a separate (op, path, values) tuple. | |
| get a separate (op, path, values) tuple. |
jirikuncar
reviewed
Jan 6, 2020
| - `path` is by default a dot-separated string of keys from the root of the | ||
| structure to the point of difference. | ||
| - If parameter `dot_notation` is set to False, path is a list of | ||
| separate key strings instead. |
Member
There was a problem hiding this comment.
Suggested change
| separate key strings instead. | |
| separate key strings instead. |
Member
|
@jirikuncar I guess you wanted to ping @mikaelho instead 😉 |
jirikuncar
reviewed
Jul 13, 2021
| {'_dictdiffer_value_key': {'type': 'datetime.date', 'value': '2021-07-06'}} | ||
| """ | ||
| transformed_value = False | ||
| for cls, transform in TRANSFORMS: |
Member
There was a problem hiding this comment.
I am not a big fun of global variables. Would it be possible to pass transformations as parameters to diff function and propagate them down? I am afraid that the performance will suffer for "dict"-only cases since you will always iterate through this list.
jirikuncar
reviewed
Jul 13, 2021
Comment on lines
+511
to
+516
| def add_transform(value_sample, represent, reconstruct): | ||
| TRANSFORMS.append((type(value_sample), {'from': represent, 'to': reconstruct})) | ||
| assert reconstruct(represent(value_sample)) == value_sample, ( | ||
| f'Could not reconstruct ({type(represent(value_sample)).__name__}) {represent(value_sample)} ' | ||
| f'to ({type(value_sample).__name__}) {value_sample}' | ||
| ) |
Member
There was a problem hiding this comment.
This could be avoided by allowing users to pass own list with transformations.
jirikuncar
reviewed
Jul 13, 2021
| def allow_import(*module_names): | ||
| for module in module_names: | ||
| importlib.import_module(module) | ||
| ALLOW_IMPORT.extend(module_names) |
Member
There was a problem hiding this comment.
similar reasoning as TRANSFORMS
jirikuncar
reviewed
Jul 13, 2021
| if isinstance(value, list): | ||
| key = int(key) | ||
| value = value[key] | ||
| value = value.__dict__ if key == '__dict__' else value[key] |
Member
There was a problem hiding this comment.
Suggested change
| value = value.__dict__ if key == '__dict__' else value[key] | |
| try: | |
| value = value[key] | |
| except KeyError: | |
| if key == '__dict__': | |
| value = value.__dict__ | |
| else: | |
| raise |
jirikuncar
reviewed
Jul 13, 2021
dictdiffer/version.py
Outdated
| """Version information for dictdiffer package.""" | ||
|
|
||
| __version__ = '0.8.2.dev2+dirty' | ||
| __version__ = '0.6.2.dev32+dirty' |
jirikuncar
reviewed
Jul 13, 2021
| @@ -639,6 +663,34 @@ def test_in_place_patch_and_revert(self): | |||
| patched_in_place = patch(changes, first, in_place=True) | |||
| assert first == patched_in_place | |||
|
|
|||
Member
There was a problem hiding this comment.
TODO
diff({'__dict__': {'a': 1}}, {'__dict__': {'a': 2}})
jirikuncar
requested changes
Jul 13, 2021
Member
jirikuncar
left a comment
jirikuncar
left a comment
There was a problem hiding this comment.
Please see my comments and revert:
pytest.ini_disable → pytest.ini
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed earlier.