generated from actions/typescript-action
-
Notifications
You must be signed in to change notification settings - Fork 0
wip support jprm yml files #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jumoog
wants to merge
2
commits into
main
Choose a base branch
from
jprm_support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's GuideImplements support for JPRM YAML build files by detecting and loading custom build metadata, branching the existing manifest-update logic to accommodate legacy and JPRM paths, and adding a new utility module plus YAML parsing dependencies. Sequence Diagram: Manifest Update Process with JPRM YAML OptionsequenceDiagram
participant MainProcess as "updateManifest()"
participant JPRMUtil as "jprm.ts module"
participant FileSystem
participant GitHubAPI
MainProcess->>JPRMUtil: findBuildYaml()
JPRMUtil-->>MainProcess: buildYamlPath (e.g., "jprm.yml" or null)
alt buildYamlPath is found
MainProcess->>JPRMUtil: loadJPRMBuildFile(buildYamlPath)
JPRMUtil->>FileSystem: readFileSync(buildYamlPath)
FileSystem-->>JPRMUtil: yamlContent
JPRMUtil->>JPRMUtil: Parse YAML content into JPRMBuildConfig
JPRMUtil-->>MainProcess: jprmConfig: JPRMBuildConfig
MainProcess->>MainProcess: Create client_payload from jprmConfig
MainProcess->>FileSystem: getMD5FromFile(zipFileName)
FileSystem-->>MainProcess: checksum
MainProcess->>GitHubAPI: POST /dispatches (with JPRM client_payload)
GitHubAPI-->>MainProcess: API Response
else buildYamlPath is null (not found or invalid)
MainProcess->>MainProcess: Execute legacy manifest update logic
MainProcess->>FileSystem: Read README.md & bug_report_form.yml
MainProcess->>MainProcess: Determine currentVersion, targetAbi
MainProcess->>MainProcess: Create client_payload (legacy)
MainProcess->>GitHubAPI: POST /dispatches (with legacy client_payload)
GitHubAPI-->>MainProcess: API Response
MainProcess->>FileSystem: Update README.md
MainProcess->>FileSystem: Update bug_report_form.yml
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Add support for JPRM YAML build files in the manifest update GitHub Action by auto-detecting and loading build.yaml/.yml for plugin metadata, falling back to the existing intro-skipper flow when no valid JPRM file is found, and consolidating dispatch, version retrieval, and documentation updates.
New Features:
Enhancements:
Build: