Skip to content

Fix set_reflash_callback #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
drebbe-intrepid merged 1 commit into from
Nov 21, 2025
Merged

Fix set_reflash_callback #223

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions src/methods.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2137,19 +2137,13 @@ PyObject* meth_set_reflash_callback(PyObject* self, PyObject* args)
char buffer[512];
return set_ics_exception(exception_runtime_error(), dll_get_error(buffer));
}
ice::Function<int __stdcall(void (*)(const wchar_t*, unsigned long))> icsneoSetReflashCallback(
ice::Function<void __stdcall(void (*)(const wchar_t*, unsigned long))> icsneoSetReflashCallback(
lib, "icsneoSetReflashCallback");
auto gil = PyAllowThreads();
if (callback == Py_None) {
if (!icsneoSetReflashCallback(NULL)) {
gil.restore();
return set_ics_exception(exception_runtime_error(), "icsneoSetReflashCallback() Failed");
}
icsneoSetReflashCallback(NULL);
} else {
if (!icsneoSetReflashCallback(&message_reflash_callback)) {
gil.restore();
return set_ics_exception(exception_runtime_error(), "icsneoSetReflashCallback() Failed");
}
icsneoSetReflashCallback(&message_reflash_callback);
}
gil.restore();
Py_RETURN_NONE;
Expand Down
Loading