Conversation
fanchen2
force-pushed
the
dev-fan
branch
23 times, most recently
from
4ee2723 to
0fe8b74
Compare
KVM/qemu/tests/ras.py
Outdated
| hw_mce = 'err_code:0x00a0:0x0090 SystemAddress:0x%s' % host_pha.lstrip('0x') | ||
| vm_mce = 'mce: Uncorrected hardware memory error in user-access at %s' % guest_pha.lstrip('0x') | ||
| hw_dmesg = process.system_output('dmesg').decode('utf-8') | ||
| s, vm_dmesg = session.cmd_status_output('dmesg') |
There was a problem hiding this comment.
same comments, need check "s".
KVM/qemu/ras.cfg
Outdated
| - srao: | ||
| error_type = "0x10" | ||
| variants: | ||
| - vm: |
There was a problem hiding this comment.
Is this variant "vm" necessary?
There was a problem hiding this comment.
I planned to add TDX case after the kernel bug get fixed.
But I just aligned with dev, TD case may need kselftest or kernel module support, will remove the "vm" here.
KVM/qemu/tests/ras.py
Outdated
|
|
||
| def prepare_vm_victim(test, params, vm=None, session=None): | ||
| """ | ||
| Compile test tool victim in host or guest. |
There was a problem hiding this comment.
Seems this function only support VM only according to the implementation, such as: vm.copy_files_to(), session.cmd_status(), so the description need to be updated, and parameter "vm" and "session" are not optional.
There was a problem hiding this comment.
I planned to deploy it for host, then found it is not necessary for this case, will clean this host setup
Signed-off-by: Farrah Chen <farrah.chen@intel.com>
|
@xhao22 Thanks for your comment, all comments have been addressed, could you take a look again? |
2 participants
No description provided.