fix!: remove invalid feedback types and add missing ones#234
Open
figueredo wants to merge 1 commit intofeat-feedback-expires-atfrom
Open
fix!: remove invalid feedback types and add missing ones#234figueredo wants to merge 1 commit intofeat-feedback-expires-atfrom
figueredo wants to merge 1 commit intofeat-feedback-expires-atfrom
Conversation
figueredo
force-pushed
the
rfc3339-fields
branch
from
33c576a to
3ad6b4c
Compare
figueredo
force-pushed
the
fix-feedback-remove-invalid-types
branch
2 times, most recently
from
ae0e4e4 to
0be2276
Compare
figueredo
changed the base branch from
rfc3339-fields
to
feat-feedback-expires-at
figueredo
force-pushed
the
fix-feedback-remove-invalid-types
branch
from
0be2276 to
6a11b1d
Compare
figueredo
force-pushed
the
feat-feedback-expires-at
branch
from
73e6c75 to
44ddd16
Compare
figueredo
force-pushed
the
fix-feedback-remove-invalid-types
branch
from
6a11b1d to
15214b1
Compare
racevedoo
approved these changes
Jul 22, 2024
figueredo
force-pushed
the
feat-feedback-expires-at
branch
from
44ddd16 to
e539a0d
Compare
figueredo
force-pushed
the
fix-feedback-remove-invalid-types
branch
from
15214b1 to
9b5b214
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Removes no longer valid feedback types and add missing ones, according to public docs.
This is a breaking change.
Checklist