You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Using the newly released serde_core seems to have significant benefit for compile times, pbjson is the main user left in Datafusion.
This is a breaking change, as it generates different code (serde_core:: instead of serde::), and also significantly moves up the required serde/serde_core versions.
There is one #[derive(Deserialize)] which I couldn't figure out yet, but I figured its worth opening this PR for early feedback.
OK, I did look into this more in depth: the issue is pbjson::private::Content and the borrowing deserialization that comes with it. If you cargo-expand the derived implementation, you end up with a lot of private serde APIs used. So we would either implement the glue code ourselves (a few hundred lines) or use -- as @AdamGS suggested -- serde-content. It's a bit of a shame that the serde_core crates are basically unusable without helpers for more complex settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the newly released
serde_coreseems to have significant benefit for compile times,pbjsonis the main user left in Datafusion.This is a breaking change, as it generates different code (
serde_core::instead ofserde::), and also significantly moves up the requiredserde/serde_coreversions.There is one
#[derive(Deserialize)]which I couldn't figure out yet, but I figured its worth opening this PR for early feedback.