Open
Conversation
Member
|
@arbazkhan56 Commit changes in develop branch, not in master branch |
Nishant2907
requested changes
Dec 19, 2020
Member
Nishant2907
left a comment
There was a problem hiding this comment.
- You have added youtube links to the list, but what we want here is the embedded links. So kindly look into that.
- Another thing is that the changes you did in the
app.jsandindex.ejs. They are not working as it should work. - Still, the previous links and list is being shown in all the subjects. So look after them too.
Member
|
@arbazkhan56 Don't delete those youtube links, those are useful in hashcode_app if you don't know flutter then just put a text in the given link and I'll guide you in that. |
arbazkhan56
commented
Dec 20, 2020
Author
arbazkhan56
left a comment
There was a problem hiding this comment.
I have solved the issue in these files. It will run easily.
Author
|
I have never worked with flutter Before. |
Nishant2907
requested changes
Dec 24, 2020
Member
Nishant2907
left a comment
There was a problem hiding this comment.
In the list.js you have added the youtube video links. Replace them with the youtube embedded video links. Rest seems fine to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the change?
Adding the javascript Tutorials
Related issue?
Issue: #3
Files edited?
Checklist:
Before you create this PR, confirm all the requirements listed below by checking the checkboxes like this (
[x]).Screenshots:
not required