transpile: Allow unused_imports and clippy::missing_safety_doc in generated code
#1511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rua
changed the title
allow pragmasunused_imports and clippy::missing_safety_doc in generated code
Contributor
Author
|
I see that in order to support clippy pragmas, I first need to make some changes in various places to allow full paths instead of just strings. But before I do all that, is that actually wanted? |
kkysen
reviewed
Dec 14, 2025
Contributor
kkysen
left a comment
kkysen
left a comment
There was a problem hiding this comment.
Which unused_imports are we generating? If we can reduce those, that'd also be good.
I see that in order to support clippy pragmas, I first need to make some changes in various places to allow full paths instead of just strings. But before I do all that, is that actually wanted?
I don't think this is particularly important, but supporting clippy pragmas should be fine I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the
unused_importsandclippy::missing_safety_docin all generated code. There's always a lot of these which makes it harder to see genuine warnings.