draft: experimental implementation of isHittable via snapshot-to-element resolution #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR explores an optimized implementation of the
isHittableattribute for the/sourceendpoint, based on reviewer suggestions.Instead of resolving each element on demand (via queries), I pre-resolve all
XCUIElementinstances usingfb_filterDescendantsWithSnapshots, and then match them back to each snapshot in the hierarchy using theirfb_uid.The goal is to improve performance by avoiding repeated queries during tree traversal, while still exposing accurate runtime
XCUIElement.hittablevalues.Key Implementation Steps
fb_flattenTreeXCUIElementinstances viafb_filterDescendantsWithSnapshotssnapshot.uid → element.hittabledirectly from matched elementsisHittableto the tree only when not excludedWhat observed
In practice, this resolution appears inaccurate in many cases:
Application,Window,Image, andOtherconsistently reportisHittable: YESdescendantsMatchingType + matchingIdentifier)📎 Related to main discussion: appium#1021
📎 Issue reference: [Feat] - Add isHittable to iOS driver appium#1005