Allow multiple GOAWAY frames #185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per rfc9113, section 6.8, GOAWAY may be resent: - if there is a delay between an earlier GOAWAY and closing the socket - to send different values > A GOAWAY frame might not immediately precede closing of the connection; a receiver of a GOAWAY that has no more use for the connection SHOULD still send a GOAWAY frame before terminating the connection. > An endpoint MAY send multiple GOAWAY frames if circumstances change.
HoneyryderChuck
force-pushed
the
allow-multiple-goaway
branch
2 times, most recently
from
23ad643 to
e337700
Compare
HoneyryderChuck
force-pushed
the
allow-multiple-goaway
branch
from
e337700 to
14fbf81
Compare
Collaborator
|
thx @zarqman |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the behavior upon a second
GOAWAYon a connection. Before, it raised aProtocolError. After, the GOAWAY is allowed with no further action.Duplicate GOAWAYs have been seen irl with
dnsdist, which uses thenghttp2library.Per rfc9113, section 6.8, GOAWAY may be resent:
if there is a delay between an earlier GOAWAY and closing the socket
to send different values
I considered letting :goaway fall through to the
elsecondition and raising after a 15 second delay. However, I believe 15 seconds would still be too small to satisfy conditions of an intentional delay between first and second GOAWAY frames.For example, a server could send GOAWAY to indicate no new streams, but continue to finish existing streams which could easily take longer than 15 seconds. When finished, the server is likely to send a second GOAWAY when preparing to close the socket. This scenario would be normal behavior for a server performing a graceful shutdown with medium-to-long running requests.