Skip to content

minor fixes for sharekit #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eric-sofisoftwarellc wants to merge 3 commits into
base: master
Choose a base branch
from
Open

minor fixes for sharekit #328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8f55d74
Remove extra #define SHKSharedWithSignature
eric-sofisoftwarellc Dec 13, 2011
64c9c98
In validate, check for length > 0, not length >= 0, to avoid trying t…
eric-sofisoftwarellc Dec 13, 2011
9492865
Add empty evernote #defines
eric-sofisoftwarellc Dec 13, 2011
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions Classes/ShareKit/SHKConfig.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,16 @@
// Append 'Shared With 'Signature to Email (and related forms)
#define SHKSharedWithSignature 0

//#define SHKEvernoteUserStoreURL @"https://sandbox.evernote.com/edam/user"
//#define SHKEvernoteNetStoreURLBase @"http://sandbox.evernote.com/edam/note/"
//#define SHKEvernoteUserStoreURL @"https://www.evernote.com/edam/user"
//#define SHKEvernoteNetStoreURLBase @"http://www.evernote.com/edam/note/"

#define SHKEvernoteUserStoreURL @""
#define SHKEvernoteNetStoreURLBase @""

#define SHKEvernoteConsumerKey @""
#define SHKEvernoteSecretKey @""

/*
UI Configuration : Basic
Expand Down Expand Up @@ -115,9 +124,6 @@
// ShareMenu Ordering
#define SHKShareMenuAlphabeticalOrder 1 // Setting this to 1 will show list in Alphabetical Order, setting to 0 will follow the order in SHKShares.plist

// Append 'Shared With 'Signature to Email (and related forms)
#define SHKSharedWithSignature 0

/*
UI Configuration : Advanced
------
Expand Down
2 changes: 1 addition & 1 deletion Classes/ShareKit/Sharers/Services/Twitter/SHKTwitter.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ - (void)shortenURLFinished:(SHKRequest *)aRequest
- (BOOL)validate
{
NSString *status = [item customValueForKey:@"status"];
return status != nil && status.length >= 0 && status.length <= 140;
return status != nil && status.length > 0 && status.length <= 140;
}

- (BOOL)send
Expand Down