Skip to content

Conversation

@phroi
Copy link
Member

@phroi phroi commented Oct 8, 2025

Adds a new app sampler under apps/sampler.

Purpose: utility to sample iCKB rate over time and produce CSV output.

Files added:

  • README.md: usage and license for iCKB Sampler.
  • src/index.ts: main sampling tool: constructs a CCC public mainnet client, generates date samples (samples function), finds corresponding block numbers via async binary search, converts values, and emits CSV rows; includes attemptLog helper; uses top-level await; exits on completion.
  • rate.csv: initial CSV sample data with historical block timestamps/values and notes.

@gemini-code-assist
Copy link

Summary of Changes

Hello @phroi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This PR adds a new sampler application to track and output historical iCKB rates to CSV. It includes the core TypeScript logic, build configurations, usage documentation, and initial sample data, along with necessary dependency updates.

Highlights

  • Intent: This pull request introduces a new application named sampler designed to sample the iCKB rate over time and generate CSV output. Its primary purpose is to provide a utility for tracking historical iCKB values on the CKB mainnet.
  • Key Changes: A new apps/sampler directory has been added, containing the core sampling tool (src/index.ts), its configuration (package.json, tsconfig.json, typedoc.json, vitest.config.mts, .npmignore), a README.md for usage instructions, and an initial rate.csv file with historical iCKB data. The src/index.ts script utilizes @ckb-ccc/core to interact with the CKB mainnet, performs an async binary search to find block numbers corresponding to specific dates, and converts block header values using @ickb/core to produce CSV output. The pnpm-lock.yaml file was updated to include the new sampler app's dependencies and minor version bumps for some indirect dependencies.
  • Reviewer Activity: No specific reviewer activity has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new sampler utility, which is a great addition for analyzing iCKB rates. The implementation is clean and the documentation is helpful. I've identified a few areas for improvement, mainly concerning code robustness, portability, and clarity. My comments include suggestions to make the script more resilient to errors and compatible across different development environments. Overall, this is a solid contribution.

@phroi
Copy link
Member Author

phroi commented Oct 8, 2025

LGM

Phroi %134

@phroi phroi merged commit bdabd60 into master Oct 8, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants