pyLCIO: adapt to changes in ROOT regarding libcppyy#215
Merged
tmadlener merged 1 commit intoiLCSoft:masterfrom Dec 16, 2025
Merged
pyLCIO: adapt to changes in ROOT regarding libcppyy#215tmadlener merged 1 commit intoiLCSoft:masterfrom
tmadlener merged 1 commit intoiLCSoft:masterfrom
Conversation
tmadlener
reviewed
Dec 16, 2025
Contributor
tmadlener
left a comment
tmadlener
left a comment
There was a problem hiding this comment.
PS: but the unit tests here hopefully cover this part somehow?
I suppose this already fails at from pyLCIO import ... in case it fails? Or do we have to trigger this in a more specific way?
tmadlener
reviewed
Dec 16, 2025
| # Cope with API change with ROOT version >= 6.21 | ||
| if ROOT.gROOT.GetVersionCode() >= (6<<16) + (21<<8) : | ||
| elif ROOT.gROOT.GetVersionCode() >= (6<<16) + (21<<8) : | ||
| from libcppyy import CPPOverload |
Contributor
There was a problem hiding this comment.
Can we add a comment here that this is removed with ROOT 6.36, so that we have a chance to remove this without having to do git archeology?
Contributor
Author
There was a problem hiding this comment.
Good idea, I added a comment.
libcppyy was moved to a non-importable location in root 6.38
andresailer
force-pushed
the
fixNewCppyy
branch
from
f110ad8 to
13327a5
Compare
tmadlener
approved these changes
Dec 16, 2025
andresailer
changed the title
andresailer
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
ENDRELEASENOTES
cf. root-project/root#20287
(I haven't really tested this)
PS: but the unit tests here hopefully cover this part somehow?