Make sure to properly cleanup type names for patched subset collections#213
Merged
tmadlener merged 5 commits intoiLCSoft:masterfrom Sep 9, 2025
Merged
Make sure to properly cleanup type names for patched subset collections#213tmadlener merged 5 commits intoiLCSoft:masterfrom
tmadlener merged 5 commits intoiLCSoft:masterfrom
Conversation
LCIO doesn't really care about this, but the typename is potentially used downstream
tmadlener
force-pushed
the
fix-subset-patching
branch
2 times, most recently
from
a1f337f to
addd522
Compare
tmadlener
force-pushed
the
fix-subset-patching
branch
from
addd522 to
5542530
Compare
tmadlener
commented
Sep 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
*from subset collections that need to be patched in to avoid confusing downstream code that uses the type name to dispatch to type specific code. Fixes k4EDM4hep2LcioConv#123CheckCollectionsutilityENDRELEASENOTES