[wip] Update cmake configuraton to targets based approach#140
Open
tmadlener wants to merge 6 commits intoiLCSoft:masterfrom
Open
[wip] Update cmake configuraton to targets based approach#140tmadlener wants to merge 6 commits intoiLCSoft:masterfrom
tmadlener wants to merge 6 commits intoiLCSoft:masterfrom
Conversation
2a0ec36 to
add5cec
Compare
- Use SIO targets - Define LCIO targets and export them properly for downstream usage - Keep some package specific install variables to keep backwards compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
ENDRELEASENOTES
Fixes #133
MacroCheckPackageVersion.his still used byFindCLHEP.cmakeso that would need to be touched as well. Keeping it for the moment.FindPythonBUILD_TESTINGbehave as expected