[Flax] Fix & Add scripts to push pretrained flax model weights to the huggingface hub#545
Open
snoop2head wants to merge 2 commits intohuggingface:mainfrom
Open
[Flax] Fix & Add scripts to push pretrained flax model weights to the huggingface hub#545snoop2head wants to merge 2 commits intohuggingface:mainfrom
snoop2head wants to merge 2 commits intohuggingface:mainfrom
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
snoop2head
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the following:
Issues above happened mainly because provided examples upload initialized model's parameters, resulting in
jibberish outputas mentioned in the issues.Fixed with 1) unreplicating params, 2) assigning back to the original flax model class, 3) pushing to the huggingface hub.
Who can review?
@patrickvonplaten
Thank you for your review and devotion to the open source project!