Support setting version in build.toml
#342
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds the `version` option to the `general` section in `build.toml`. The version will be written to the build metadata and will be used by `kernels upload` to upload builds to a versioned branch.
This allows version-based uploading to kick in when no branch is specified.
drbh
approved these changes
Jan 13, 2026
Collaborator
drbh
left a comment
drbh
left a comment
There was a problem hiding this comment.
lgtm, just left a question about the version type
|
|
||
| pub struct General { | ||
| pub name: String, | ||
| pub version: Option<usize>, |
Collaborator
There was a problem hiding this comment.
likely overly pedantic, but maybe we want to be more strict on the version and disallow negative numbers or 0? additionally maybe we want to use a less ambiguous type like u32.
conversely maybe we want a more open ended type like a string? just thinking out loud here..
curious to hear your thoughts on the type?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the
versionoption to thegeneralsection inbuild.toml. The version will be written to the build metadata and will be used bykernels uploadto upload builds to a versioned branch.