-
Notifications
You must be signed in to change notification settings - Fork 14
[Draft] Port to 1.21.11, implement Inventory/Container Sync & fix bugs #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
RCUTANF
wants to merge
59
commits into
hpfxd:mc/1.21.4
Choose a base branch
from
RCUTANF:master
base: mc/1.21.4
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7745359. For some reason the ItemStack codecs arent working in the new 1.21.5 update?
Fixes from Sigma
…LAN settings in multiplayer game
…Stack serialization for fixing HotBar item decode fail.
…case handler cant recognize null item
…lPose in renderItemInHand
# Conflicts: # fabric/gradle.properties # fabric/src/client/java/com/hpfxd/spectatorplus/fabric/client/mixin/GameRendererMixin.java # fabric/src/client/java/com/hpfxd/spectatorplus/fabric/client/mixin/GuiMixin.java # fabric/src/client/java/com/hpfxd/spectatorplus/fabric/client/sync/ClientSyncController.java # fabric/src/main/java/com/hpfxd/spectatorplus/fabric/sync/packet/ClientboundEffectsSyncPacket.java # fabric/src/main/java/com/hpfxd/spectatorplus/fabric/sync/packet/ClientboundExperienceSyncPacket.java # fabric/src/main/java/com/hpfxd/spectatorplus/fabric/sync/packet/ClientboundFoodSyncPacket.java # fabric/src/main/java/com/hpfxd/spectatorplus/fabric/sync/packet/ClientboundHotbarSyncPacket.java # fabric/src/main/java/com/hpfxd/spectatorplus/fabric/sync/packet/ClientboundInventorySyncPacket.java # fabric/src/main/java/com/hpfxd/spectatorplus/fabric/sync/packet/ClientboundScreenCursorSyncPacket.java # fabric/src/main/java/com/hpfxd/spectatorplus/fabric/sync/packet/ClientboundScreenSyncPacket.java # fabric/src/main/java/com/hpfxd/spectatorplus/fabric/sync/packet/ClientboundSelectedSlotSyncPacket.java # fabric/src/main/java/com/hpfxd/spectatorplus/fabric/sync/packet/ServerboundOpenedInventorySyncPacket.java # fabric/src/main/java/com/hpfxd/spectatorplus/fabric/sync/packet/ServerboundRequestInventoryOpenPacket.java # paper/gradle.properties # settings.gradle.kts
…layerMixin Connors Fixes # Conflicts: # fabric/gradle.properties # fabric/src/client/java/com/hpfxd/spectatorplus/fabric/client/mixin/LivingEntityMixin.java # paper/build.gradle.kts
…tead of using client side hacking data
…ntory data is sent correctly
…ntory sync packet
- Split `fabric` module into `fabric-core`, `fabric-1.21.10`, and `fabric-1.21.11`.
- Split `paper` module into `paper-core`, `paper-1.21.10`, and `paper-1.21.11`.
- Configure specific dependencies for 1.21.10 and 1.21.11 version modules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR: Opening this as a draft since there are a lot of changes involved. I'm happy to discuss the implementation details before merging.
I realize that bundling multiple changes in a single PR isn't standard practice. However, given that the repository is quite outdated and the scope of the updates is large, I'm presenting them this way to make the review process easier.
This PR updates the mod to Minecraft 1.21.11 (Fabric) and finally implements
containSyncandinventorySync.Key Changes:
DummyContainer,SyncedInventoryScreen).