-
Notifications
You must be signed in to change notification settings - Fork 120
feat(chart): simplify update logic and deprecate some flags #431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
medbenmakhlouf
wants to merge
18
commits into
highcharts:master
Choose a base branch
from
medbenmakhlouf:fix-sync-issue
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s and simplifying chart creation logic
…ing chart instance
… better loading sequence
… storing chart instance
… redraw functionality
Contributor
Author
|
@karolkolodziej Thanks in advance for the review! 😉 |
Contributor
Author
|
fix : #428 |
Member
|
We always assumed the wrapper would handle updates based on the input, and now that responsibility shifts to the implementer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This Pull Request introduces significant improvements to the Highcharts wrapper API, focusing on simplifying the chart update logic and giving developers granular control over the rendering lifecycle.
By moving away from "black-box" input bindings, we are streamlining API usage and exposing the native Highcharts instance directly. This allows for more performant and predictable chart updates
Key Changes
The following inputs are now deprecated and will be removed in a future release. Please migrate to the new chartInstance approach described below.
[(update)]and[(oneToOne)]💻 Usage Example
Instead of relying on two-way binding to trigger updates, developers should now capture the chart instance and call the
.update()method manually (e.g., on a button click or signal effect).HTML Template: